feat: change ffi wallet recovery interface #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the FFI wallet recovery interface to accept a list of base node peers for recovery instead of only a single peer. This will enable the mobile wallet to pass all seed peers to the recovery process instead of only a single peer.
SWvheerden
reviewed
Oct 16, 2024
Test Results (CI) 3 files 129 suites 35m 41s ⏱️ Results for commit e270ef6. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 38m 11s ⏱️ + 38m 11s For more details on these failures, see this check. Results for commit e270ef6. ± Comparison against base commit 1319e24. ♻️ This comment has been updated with latest results. |
SWvheerden
approved these changes
Oct 16, 2024
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 17, 2024
* development: feat: change ffi wallet recovery interface (tari-project#6636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the FFI wallet recovery interface to accept a list of base node peers for recovery instead of only a single peer. This will enable the mobile wallet to pass all seed peers to the recovery process instead of only a single peer.
Motivation and Context
The recovery process for the mobile wallet should work in the same way that the console wallet does.
How Has This Been Tested?
Must be tested with system-level tests with the mobile wallet.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes
BREAKING CHANGE: Wallet FFI method
pub unsafe extern "C" fn wallet_start_recovery(had an interface update.